When creating an account with MAS, change the prompt parameter to create
#3635
Conversation
bmarty
requested review from
ganfra and
sandhose
and removed request for
a team
| } | ||
| appendQueryParameter(key, value) | ||
| }.build() | ||
| } |
There was a problem hiding this comment.
Only appendQueryParameter exists in Uri.Builder, so sadly, I had to create this extension.
| // In this case, add or replace the "prompt" parameter to "create" | ||
| val newUrl = oidcDetails.url.toUri() | ||
| .setQueryParameter("prompt", "create") | ||
| .toString() |
There was a problem hiding this comment.
Note that the provided value for the "prompt" parameter on beta.matrix.org is "consent".
bmarty
changed the title
prompt parameter to createprompt parameter to create
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
There was a problem hiding this comment.
This is right, although I'm surprised the SDK doesn't surface this parameter?
There is a setter here: https://github.com/matrix-org/matrix-rust-sdk/blob/9c6413551cd6e15f01453e57178fe98e0d12200b/crates/matrix-sdk/src/oidc/auth_code_builder.rs#L77-L80
Which is being used here: https://github.com/matrix-org/matrix-rust-sdk/blob/9c6413551cd6e15f01453e57178fe98e0d12200b/crates/matrix-sdk/src/oidc/mod.rs#L473
And exposed in the bindings here: https://github.com/matrix-org/matrix-rust-sdk/blob/9c6413551cd6e15f01453e57178fe98e0d12200b/bindings/matrix-sdk-ffi/src/client.rs#L367
I feel like there should be an url_for_oidc_registration equivalent in the SDK?
|
OK so maybe we could improve the existing Rust API, to replace @jmartinesp do you think this would be possible? |
|
From a very quick look at the code, it seems feasible, although I'd rather make the |
|
Yes, an enum would be better than a String. Thanks! |
|
Closing this we will get a better way to handle this thanks to Jorge's work in matrix-org/matrix-rust-sdk#4131. |
Content
When user is creating account, load the url page directly in the account creation mode by changing (or adding) the
prompturl parameter tocreate.@sandhose does it make sense to you?
Motivation and context
Improve user experience with MAS and closes #3627
Screenshots / GIFs
MAS-account_creation_before.mp4
MAS-account_creation_after.mp4
Tests
Tested devices
Checklist